[all-commits] [llvm/llvm-project] ce0521: [Reduce] Argument reduction: don't try to drop ter...

Roman Lebedev via All-commits all-commits at lists.llvm.org
Mon Jul 20 14:06:35 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ce052110ac9c03f14e16a0f46697da2eabc7ac4c
      https://github.com/llvm/llvm-project/commit/ce052110ac9c03f14e16a0f46697da2eabc7ac4c
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    A llvm/test/Reduce/remove-args-used-by-ret.ll
    M llvm/tools/llvm-reduce/deltas/ReduceArguments.cpp

  Log Message:
  -----------
  [Reduce] Argument reduction: don't try to drop terminator instructions

Newly-added test previously crashed.

While it is up for debate whether or not instruction reduction
should be indiscriminate in instruction dropping (there you can
just ensure that the test case is still -verify'ies), here
if we drop terminator, CloneFunctionInto() will immediately crash.

So let's not do that :)




More information about the All-commits mailing list