[all-commits] [llvm/llvm-project] 8b16e4: Enable -Wsuggest-override in the LLVM build

[kepler-5 via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8b16e45f66e24e4c10e2cea1b70d2b85a7ce64d5
      https://github.com/llvm/llvm-project/commit/8b16e45f66e24e4c10e2cea1b70d2b85a7ce64d5
  Author: Logan Smith <logan.r.smith0 at gmail.com>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M libcxx/CMakeLists.txt
    M libcxxabi/CMakeLists.txt
    M lldb/unittests/CMakeLists.txt
    M llvm/cmake/modules/HandleLLVMOptions.cmake
    M llvm/utils/benchmark/CMakeLists.txt
    M llvm/utils/unittest/CMakeLists.txt

  Log Message:
  -----------
  Enable -Wsuggest-override in the LLVM build

This patch adds Clang's new (and GCC's old) -Wsuggest-override to the warning flags for the LLVM build. The warning is a stronger form of -Winconsistent-missing-override which warns _everywhere_ that override is missing, not just in places where it's inconsistent within a class.

Some directories in the monorepo need the warning disabled for compatibility's, or sanity's, sake; in particular, libcxx/libcxxabi, and any code implementing or interoperating with googletest, googlemock, or google benchmark (which do not themselves use override). This patch adds -Wno-suggest-override to the relevant CMakeLists.txt's to accomplish this.

Differential Revision: https://reviews.llvm.org/D84126