[all-commits] [llvm/llvm-project] 3a108a: [LLD][COFF] Skip computation of the undefined symb...

sylvain-audi via All-commits all-commits at lists.llvm.org
Mon Jul 20 10:46:58 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 3a108ab256dba7b5a7304f0e83818673d334405f
      https://github.com/llvm/llvm-project/commit/3a108ab256dba7b5a7304f0e83818673d334405f
  Author: Sylvain Audi <sylvain.audi at ubisoft.com>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M lld/COFF/SymbolTable.cpp
    A lld/test/COFF/Inputs/undefined-symbol-multi-lto.ll
    M lld/test/COFF/undefined-symbol-multi.s

  Log Message:
  -----------
  [LLD][COFF] Skip computation of the undefined symbols references that are not shown

The "undefined symbol" error message from lld-link displays up to 3 references to that symbol, and the number of extra references not shown.

This patch removes the computation of the strings for those extra references.

It fixes a freeze of lld-link we accidentally encountered when activating asan on a large project, without linking with the asan library.
In that case, __asan_report_load8 was referenced more than 2 million times, causing the computation of that many display strings, of which only 3 were used.

Differential Revision: https://reviews.llvm.org/D83510




More information about the All-commits mailing list