[all-commits] [llvm/llvm-project] cf5df4: Revert "[AddressSanitizer] Don't use weak linkage ...

[Leonard Chan via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: cf5df40c4cf1a53a02ab1d56a488642e3dda8f6d
      https://github.com/llvm/llvm-project/commit/cf5df40c4cf1a53a02ab1d56a488642e3dda8f6d
  Author: Leonard Chan <leonardchan at google.com>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
    M llvm/test/Instrumentation/AddressSanitizer/global_metadata.ll

  Log Message:
  -----------
  Revert "[AddressSanitizer] Don't use weak linkage for __{start,stop}_asan_globals"

This reverts commit d76e62fdb7a93d9a33f642b6b528f2562cc3c3f4.

Reverting since this can lead to linker errors:

```
ld.lld: error: undefined hidden symbol: __start_asan_globals
```

when using --gc-sections. The linker can discard __start_asan_globals
once there are no more `asan_globals` sections left, which can lead to
this error if we have external linkages to them.