[all-commits] [llvm/llvm-project] f2eef8: [X86] Add test case for PR46455.

topperc via All-commits all-commits at lists.llvm.org
Fri Jul 17 02:47:47 PDT 2020


  Branch: refs/heads/release/11.x
  Home:   https://github.com/llvm/llvm-project
  Commit: f2eef8ccade595a97322a245484acf95de18be52
      https://github.com/llvm/llvm-project/commit/f2eef8ccade595a97322a245484acf95de18be52
  Author: Craig Topper <craig.topper at intel.com>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp
    A llvm/test/CodeGen/X86/pr46455.ll

  Log Message:
  -----------
  [X86] Add test case for PR46455.

(cherry picked from commit 9adf7461f721170419058684a8d3f9228d641d59)


  Commit: fc2d3ffeb890d6e26d55c50b4a343d1e1e4896d5
      https://github.com/llvm/llvm-project/commit/fc2d3ffeb890d6e26d55c50b4a343d1e1e4896d5
  Author: Craig Topper <craig.topper at intel.com>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp
    M llvm/test/CodeGen/X86/pr46455.ll

  Log Message:
  -----------
  [X86] Move integer hadd/hsub formation into a helper function shared by combineAdd and combineSub.

There was a lot of duplicate code here for checking the VT and
subtarget. Moving it into a helper avoids that.

It also fixes a bug that combineAdd reused Op0/Op1 after a call
to isHorizontalBinOp may have changed it. The new helper function
has its own local version of Op0/Op1 that aren't shared by other
code.

Fixes PR46455.

Reviewed By: spatel, bkramer

Differential Revision: https://reviews.llvm.org/D83971

(cherry picked from commit 5408024fa87e0b23b169fec07913bd4357acdbc4)


Compare: https://github.com/llvm/llvm-project/compare/f7587ec858da...fc2d3ffeb890


More information about the All-commits mailing list