[all-commits] [llvm/llvm-project] b16dfb: [Darwin] Fix OS version checks inside simulators

Julian Lettner via All-commits all-commits at lists.llvm.org
Thu Jul 16 10:48:50 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b16dfbead21a458799a0dab96599eb15f5d9b7ea
      https://github.com/llvm/llvm-project/commit/b16dfbead21a458799a0dab96599eb15f5d9b7ea
  Author: Julian Lettner <julian.lettner at apple.com>
  Date:   2020-07-16 (Thu, 16 Jul 2020)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/sanitizer_mac.cpp
    M compiler-rt/lib/sanitizer_common/tests/sanitizer_mac_test.cpp

  Log Message:
  -----------
  [Darwin] Fix OS version checks inside simulators

compiler-rt checks OS versions by querying the Darwin kernel version.
This is not necessarily correct inside the simulators if the simulator
runtime is not aligned with the host macOS.  Let's instead check the
`SIMULATOR_RUNTIME_VERSION` env var.

Note that we still use the old code path as a fallback in case the
`SIMULATOR_RUNTIME_VERSION` environment variable isn't set.

rdar://63031937

Reviewers: delcypher

Differential Revision: https://reviews.llvm.org/D79979




More information about the All-commits mailing list