[all-commits] [llvm/llvm-project] e122eb: [AMDGPU][MC] Corrected MTBUF parsing and decoding

[dpreobra via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e122eba185055fb848cc7efc578035716dc1fec4
      https://github.com/llvm/llvm-project/commit/e122eba185055fb848cc7efc578035716dc1fec4
  Author: Dmitry Preobrazhensky <dmitry.preobrazhensky at amd.com>
  Date:   2020-07-15 (Wed, 15 Jul 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
    M llvm/lib/Target/AMDGPU/BUFInstructions.td
    M llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp
    M llvm/lib/Target/AMDGPU/SIDefines.h
    M llvm/lib/Target/AMDGPU/SIInstrInfo.td
    M llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
    M llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
    M llvm/test/MC/AMDGPU/mtbuf-gfx10.s
    M llvm/test/MC/AMDGPU/mtbuf.s
    M llvm/test/MC/Disassembler/AMDGPU/mtbuf_gfx10.txt
    M llvm/test/MC/Disassembler/AMDGPU/mtbuf_vi.txt

  Log Message:
  -----------
  [AMDGPU][MC] Corrected MTBUF parsing and decoding

MTBUF implementation has many issues and this change addresses most of these:
- refactored duplicated code;
- hardcoded constants moved out of high-level code;
- fixed a decoding error when nfmt or dfmt are zero (bug 36932);
- corrected parsing of operand separators (bug 46403);
- corrected handling of missing operands (bug 46404);
- corrected handling of out-of-range modifiers (bug 46421);
- corrected default value (bug 46467).

Reviewers: arsenm, rampitec, vpykhtin, artem.tamazov, kzhuravl

Differential Revision: https://reviews.llvm.org/D83760