[all-commits] [llvm/llvm-project] b98f41: [mlir][DialectConversion] Emit an error if an oper...

[River Riddle via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b98f414a04e19202669a4273e620bc12b5054413
      https://github.com/llvm/llvm-project/commit/b98f414a04e19202669a4273e620bc12b5054413
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2020-07-14 (Tue, 14 Jul 2020)

  Changed paths:
    M mlir/lib/Transforms/DialectConversion.cpp
    A mlir/test/Transforms/test-legalize-erased-op-with-uses.mlir

  Log Message:
  -----------
  [mlir][DialectConversion] Emit an error if an operation marked as erased has live users after conversion

Up until now, there has been an implicit agreement that when an operation is marked as
"erased" all uses of that operation's results are guaranteed to be removed during conversion. How this works in practice is that there is either an assert/crash/asan failure/etc. This revision adds support for properly detecting when an erased operation has dangling users, emits and error and fails the conversion.

Differential Revision: https://reviews.llvm.org/D82830