[all-commits] [llvm/llvm-project] f7f801: [lldb-vscode] Add Support for Module Event

walter erquinigo via All-commits all-commits at lists.llvm.org
Fri Jul 10 16:51:19 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f7f80159753ba725f7e32529fcc369bc358efbb3
      https://github.com/llvm/llvm-project/commit/f7f80159753ba725f7e32529fcc369bc358efbb3
  Author: Yifan Shen <aelitashen at fb.com>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py
    A lldb/test/API/tools/lldb-vscode/module/Makefile
    A lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py
    A lldb/test/API/tools/lldb-vscode/module/main.cpp
    M lldb/tools/lldb-vscode/JSONUtils.cpp
    M lldb/tools/lldb-vscode/JSONUtils.h
    M lldb/tools/lldb-vscode/VSCode.cpp
    M lldb/tools/lldb-vscode/lldb-vscode.cpp

  Log Message:
  -----------
  [lldb-vscode] Add Support for Module Event

Summary:
Whenever a module is created, removed or changed, lldb-vscode is now sending an event that can be interpreted by the IDE so that modules can be rendered in the IDE, like the tree view in this screenshot

{F12229758}

Reviewers: wallace, clayborg, kusmour, aadsm

Reviewed By: clayborg

Subscribers: cfe-commits, labath, lldb-commits

Tags: #lldb, #clang

Differential Revision: https://reviews.llvm.org/D82477


  Commit: 03ef61033ff5e1e40518f14f642e4ad8d686974c
      https://github.com/llvm/llvm-project/commit/03ef61033ff5e1e40518f14f642e4ad8d686974c
  Author: Yifan Shen <aelitashen at fb.com>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py
    M lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py
    M lldb/tools/lldb-vscode/JSONUtils.cpp
    M lldb/tools/lldb-vscode/JSONUtils.h
    M lldb/tools/lldb-vscode/lldb-vscode.cpp

  Log Message:
  -----------
  [lldb-vscode] Add Compile Unit List to Modules View

Summary: User can expand and check compile unit list for the modules that have debug info.

Reviewers: wallace, clayborg

Reviewed By: clayborg

Subscribers: aprantl, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D83072


  Commit: 881af6eb0030986876d3b80668193e5c3c04a87c
      https://github.com/llvm/llvm-project/commit/881af6eb0030986876d3b80668193e5c3c04a87c
  Author: Walter Erquinigo <waltermelon at fb.com>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M lldb/test/API/tools/lldb-vscode/module/Makefile
    M lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py
    A lldb/test/API/tools/lldb-vscode/module/foo.cpp
    A lldb/test/API/tools/lldb-vscode/module/foo.h
    M lldb/test/API/tools/lldb-vscode/module/main.cpp

  Log Message:
  -----------
  [lldb-vscode] Fix TestVSCode_module

For some reason this works on the original author's machine, but not on my. So I'm using a safer approach of using an unstripped dynamic library to place breakpoints on. The author was placing a breakpoint on the main symbol of a stripped library and for some reason it worked on their machine, but it shouldn't have...

Offender diff: D82477


Compare: https://github.com/llvm/llvm-project/compare/e54b22840885...881af6eb0030


More information about the All-commits mailing list