[all-commits] [llvm/llvm-project] 00c9a5: CrashTracer: clang at clang: llvm::BitstreamWriter...

[JF Bastien via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 00c9a504aeed2603bd8bc9b89d753534e929c8e8
      https://github.com/llvm/llvm-project/commit/00c9a504aeed2603bd8bc9b89d753534e929c8e8
  Author: Oliver Hunt <ohunt at apple.com>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticFrontendKinds.td
    M clang/lib/Frontend/SerializedDiagnosticPrinter.cpp

  Log Message:
  -----------
  CrashTracer: clang at clang: llvm::BitstreamWriter::ExitBlock

Add a guard for re-entering an SDiagsWriter's HandleDiagnostics
method after we've started finalizing. This is a generic catch
all for unexpected fatal errors so we don't recursive crash inside
the generic llvm error handler.

We also add logic to handle the actual error case in
llvm::~raw_fd_ostream caused by failing to clear errors before
it is destroyed.

<rdar://problem/63335596>