[all-commits] [llvm/llvm-project] 746279: Move default argument instantiation to SemaTemplat...

Richard Smith via All-commits all-commits at lists.llvm.org
Thu Jul 9 17:25:04 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7462793be771712092de4c31fef1b04ac365ccea
      https://github.com/llvm/llvm-project/commit/7462793be771712092de4c31fef1b04ac365ccea
  Author: Richard Smith <richard at metafoo.co.uk>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M clang/include/clang/Sema/Sema.h
    M clang/lib/Sema/SemaExpr.cpp
    M clang/lib/Sema/SemaTemplateInstantiateDecl.cpp

  Log Message:
  -----------
  Move default argument instantiation to SemaTemplateInstantiateDecl.cpp.

No functionality change intended.


  Commit: a5569f089844209dbea2e3241460173d7b6b1420
      https://github.com/llvm/llvm-project/commit/a5569f089844209dbea2e3241460173d7b6b1420
  Author: Richard Smith <richard at metafoo.co.uk>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M clang/include/clang/AST/Decl.h
    M clang/lib/AST/Decl.cpp
    M clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
    M clang/test/SemaTemplate/default-arguments-cxx0x.cpp

  Log Message:
  -----------
  Push parameters into the local instantiation scope before instantiating
a default argument.

Default arguments can (after recent language changes) refer to
parameters of the same function. Make sure they're added to the local
instantiation scope before transforming a default argument so that we
can remap such references to them properly.


  Commit: f721e0582b158c60c56d2601235b6d60758f4d7a
      https://github.com/llvm/llvm-project/commit/f721e0582b158c60c56d2601235b6d60758f4d7a
  Author: Richard Smith <richard at metafoo.co.uk>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M clang/include/clang/AST/DeclBase.h
    M clang/lib/AST/DeclBase.cpp
    M clang/lib/Sema/SemaTemplateInstantiate.cpp
    M clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
    M clang/test/SemaTemplate/default-arguments-cxx0x.cpp
    M clang/test/SemaTemplate/dependent-expr.cpp

  Log Message:
  -----------
  PR46648: Do not eagerly instantiate default arguments for a generic
lambda when instantiating a call operator specialization.

We previously incorrectly thought that such substitution was happening
in the context of substitution into a local scope, which is a context
where we should perform eager default argument instantiation.


Compare: https://github.com/llvm/llvm-project/compare/3847a6ae759e...f721e0582b15


More information about the All-commits mailing list