[all-commits] [llvm/llvm-project] f40b11: Recommit "[X86] Merge the FEATURE_64BIT and FEATUR...

topperc via All-commits all-commits at lists.llvm.org
Thu Jul 9 14:53:24 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f40b11325e368667cf1dd91922d57dcef8069c8a
      https://github.com/llvm/llvm-project/commit/f40b11325e368667cf1dd91922d57dcef8069c8a
  Author: Craig Topper <craig.topper at intel.com>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M llvm/include/llvm/Support/X86TargetParser.def
    M llvm/lib/Support/Host.cpp
    M llvm/lib/Support/X86TargetParser.cpp

  Log Message:
  -----------
  Recommit "[X86] Merge the FEATURE_64BIT and FEATURE_EM64T bits in X86TargetParser.def."

This time without the change to make operator| use operator&=.
That seems to be the source of the gcc 5.3 miscompile.

Original commit message:
These represent the same thing but 64BIT only showed up from
getHostCPUFeatures providing a list of featuers to clang. While
EM64T showed up from getting the features for a named CPU.

EM64T didn't have a string specifically so it would not be passed
up to clang when getting features for a named CPU. While 64bit
needed a name since that's how it is index.

Merge them by filtering 64bit out before sending features to clang
for named CPUs.




More information about the All-commits mailing list