[all-commits] [llvm/llvm-project] caa423: Revert "[InstCombine] Lower infinite combine loop ...

[Roman Lebedev via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: caa423eef0d128f35ac11ddbce34964caafb61c1
      https://github.com/llvm/llvm-project/commit/caa423eef0d128f35ac11ddbce34964caafb61c1
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstructionCombining.cpp

  Log Message:
  -----------
  Revert "[InstCombine] Lower infinite combine loop detection thresholds"

And just after 3 days, we have a hit in `InstCombiner::mergeStoreIntoSuccessor()`:
https://bugs.llvm.org/show_bug.cgi?id=46661

To be recommitted once that is addressed.

This reverts commit cd7f8051ac7b6f08734102446482c1e5d951bfcc.


  Commit: 29a9dd5bfe50be9b6aecbe95c6670734e5ee29c5
      https://github.com/llvm/llvm-project/commit/29a9dd5bfe50be9b6aecbe95c6670734e5ee29c5
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M llvm/docs/CodingStandards.rst

  Log Message:
  -----------
  [Docs] CodingStandards: for_each is discouraged

Summary:
As per disscussion in D83351, using `for_each` is potentially confusing,
at least in regards to inconsistent style (there's less than 100 `for_each`
usages in LLVM, but ~100.000 `for` range-based loops

Therefore, it should be avoided.

Reviewers: dblaikie, nickdesaulniers

Reviewed By: dblaikie, nickdesaulniers

Subscribers: hubert.reinterpretcast, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D83431


  Commit: d8bf5e8048dbd1f726d50b43fa4f8ed4fa9a5178
      https://github.com/llvm/llvm-project/commit/d8bf5e8048dbd1f726d50b43fa4f8ed4fa9a5178
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M llvm/tools/llvm-reduce/deltas/ReduceOperandBundles.cpp

  Log Message:
  -----------
  [NFCI][llvm-reduce] OperandBundleCounter: drop pointless constructor

Reviewers: nickdesaulniers, dblaikie

Reviewed By: nickdesaulniers

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D83435


  Commit: 6b824415a21c188adfcabbb61ac8cf5d44b8e236
      https://github.com/llvm/llvm-project/commit/6b824415a21c188adfcabbb61ac8cf5d44b8e236
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M llvm/tools/llvm-reduce/deltas/ReduceOperandBundles.cpp

  Log Message:
  -----------
  [NFC][llvm-reduce] Purify for_each usage in Operand Bundles into range-based for loop

Summary:
As per lengthy/heated disscussion in D83351,
and CodingStandards D83431.

Reviewers: dblaikie, nickdesaulniers

Reviewed By: nickdesaulniers

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D83434


  Commit: 03640ee0fa73c6eaf8cb12050203027239136789
      https://github.com/llvm/llvm-project/commit/03640ee0fa73c6eaf8cb12050203027239136789
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    A llvm/test/Reduce/remove-attributes-from-intrinsic-like-functions.ll
    A llvm/test/Reduce/remove-attributes-from-intrinsics.ll
    A llvm/test/Reduce/remove-call-site-attributes.ll
    A llvm/test/Reduce/remove-function-attributes.ll
    A llvm/test/Reduce/remove-global-variable-attributes.ll
    M llvm/tools/llvm-reduce/CMakeLists.txt
    M llvm/tools/llvm-reduce/DeltaManager.h
    A llvm/tools/llvm-reduce/deltas/ReduceAttributes.cpp
    A llvm/tools/llvm-reduce/deltas/ReduceAttributes.h
    M llvm/utils/gn/secondary/llvm/tools/llvm-reduce/BUILD.gn

  Log Message:
  -----------
  [llvm-reduce] Reducing attributes

Summary:
This handles all three places where attributes could currently be - `GlobalVariable`, `Function` and `CallBase`.
For last two, it correctly handles all three possible attribute locations (return value, arguments and function itself)

There was a previous attempt at it D73853,
which was committed in rGfc62b36a000681c01e993242b583c5ec4ab48a3c,
but then reverted all the way back in rGb12176d2aafa0ccb2585aa218fc3b454ba84f2a9
due to some (osx?) test failures.

Reviewers: nickdesaulniers, dblaikie, diegotf, george.burgess.iv, jdoerfert, Tyker, arsenm

Reviewed By: nickdesaulniers

Subscribers: wdng, MaskRay, arsenm, llvm-commits, mgorny

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D83351


Compare: https://github.com/llvm/llvm-project/compare/53e38c85a8a6...03640ee0fa73