[all-commits] [llvm/llvm-project] 7177e6: [lldb/Core] Fix crash in ValueObject::CreateChildA...

Med Ismail Bennani via All-commits all-commits at lists.llvm.org
Tue Jul 7 11:38:25 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7177e63fb554cfac3c252327e344fb5a17d6bd65
      https://github.com/llvm/llvm-project/commit/7177e63fb554cfac3c252327e344fb5a17d6bd65
  Author: Med Ismail Bennani <medismail.bennani at gmail.com>
  Date:   2020-07-07 (Tue, 07 Jul 2020)

  Changed paths:
    M lldb/source/Core/ValueObject.cpp
    M lldb/test/API/functionalities/target_var/Makefile
    M lldb/test/API/functionalities/target_var/TestTargetVar.py
    R lldb/test/API/functionalities/target_var/globals.c
    R lldb/test/API/functionalities/target_var/globals.ll
    A lldb/test/API/functionalities/target_var/main.c

  Log Message:
  -----------
  [lldb/Core] Fix crash in ValueObject::CreateChildAtIndex

The patch fixes a crash in ValueObject::CreateChildAtIndex caused by a
null pointer dereferencing. This is a corner case that is happening when
trying to dereference a variable with an incomplete type, and this same
variable doesn't have a synthetic value to get the child ValueObject.

If this happens, lldb will now return a null pointer that will results
in an error message.

rdar://65181171

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>




More information about the All-commits mailing list