[all-commits] [llvm/llvm-project] 2cdf10: [lldb/DWARF] Add a utility function for (forceful)...

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2cdf108d329bda280948ad634aa0a070337a5f88
      https://github.com/llvm/llvm-project/commit/2cdf108d329bda280948ad634aa0a070337a5f88
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-07-07 (Tue, 07 Jul 2020)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h

  Log Message:
  -----------
  [lldb/DWARF] Add a utility function for (forceful) completion of types

Summary:
Unify the code for requiring a complete type and move it into a single
place. The only functional change is that the "cannot start a definition
of an incomplete type" is upgrated from a runtime error/warning to an
lldbassert. An plain assert might also be fine, since (AFAICT) this can
only happen in case of a programmer error.

Reviewers: teemperor, aprantl, shafik

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D83199