[all-commits] [llvm/llvm-project] 521ebc: GlobalISel: Move finalizeLowering call later
Matt Arsenault via All-commits
all-commits at lists.llvm.org
Mon Jul 6 06:23:10 PDT 2020
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 521ebc168152ab72047e2e7c81c8c6724b3e7623
https://github.com/llvm/llvm-project/commit/521ebc168152ab72047e2e7c81c8c6724b3e7623
Author: Matt Arsenault <Matthew.Arsenault at amd.com>
Date: 2020-07-06 (Mon, 06 Jul 2020)
Changed paths:
M llvm/lib/CodeGen/GlobalISel/InstructionSelect.cpp
Log Message:
-----------
GlobalISel: Move finalizeLowering call later
This matches the DAG behavior where this is called after the loop
checking for calls. The AMDGPU implementation depends on knowing if
there are calls in the function or not, so move this later.
Another problem is finalizeLowering is actually called twice; I was
seeing weird inconsistencies since the first call would produce
unexpected results and the second run would correct them in some
contexts. Since this requires disabling the verifier, and it's useful
to serialize the MIR immediately after selection, FinalizeISel should
probably not be a real pass.
More information about the All-commits
mailing list