[all-commits] [llvm/llvm-project] afd81a: [llvm-objcopy] Fix crash when removing symbol tabl...

[Georgy Komarov via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: afd81a637dfc79d2960ef8add1c697cb81c929ef
      https://github.com/llvm/llvm-project/commit/afd81a637dfc79d2960ef8add1c697cb81c929ef
  Author: Georgy Komarov <jubnzv at gmail.com>
  Date:   2020-07-05 (Sun, 05 Jul 2020)

  Changed paths:
    A llvm/test/tools/llvm-objcopy/ELF/add-symbol-new-symtab.test
    M llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp
    M llvm/tools/llvm-objcopy/ELF/Object.cpp
    M llvm/tools/llvm-objcopy/ELF/Object.h

  Log Message:
  -----------
  [llvm-objcopy] Fix crash when removing symbol table at same time as adding a symbol

This patch resolves crash that occurs when user wanted to remove all
symbols and add a brand new one using:

```
llvm-objcopy -R .symtab --add-symbol foo=1234 in.o out.o
```

Before these changes the symbol table internally being null when adding
new symbols. For now we will regenerate symtab in this case.

This fixes: https://bugs.llvm.org/show_bug.cgi?id=43930

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D82935