[all-commits] [llvm/llvm-project] 05c5ff: [gn build] make stage2_unix_toolchain set clang_ba...

[Nico Weber via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 05c5ff5ab0b4d7cec25210bce7444827c25d71b1
      https://github.com/llvm/llvm-project/commit/05c5ff5ab0b4d7cec25210bce7444827c25d71b1
  Author: Nico Weber <thakis at chromium.org>
  Date:   2020-07-04 (Sat, 04 Jul 2020)

  Changed paths:
    M llvm/utils/gn/build/toolchain/BUILD.gn

  Log Message:
  -----------
  [gn build] make stage2_unix_toolchain set clang_base_path

This fixes the build of compiler-rt on macOS when _not_ using
clang_base_path in args.gn: Xcode clang knows where to find the
SDK, but regular clang doesn't and needs a -isysroot parameter.
We correctly add that parameter when clang_base_path is set,
but else we omit it. If clang_base_path was not set, we also
didn't add the flag for stage2_unix_toolchain() when we build
compiler-rt with just-built clang.

Make stage2_unix_toolchain() use clang_base_path instead of setting
cc / cxx. It's less code, and it gets things like this right.