[all-commits] [llvm/llvm-project] 3b8ae1: [InstCombine] fix miscompile from umul_with_overfl...

RotateRight via All-commits all-commits at lists.llvm.org
Sat Jul 4 08:21:12 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 3b8ae1001f678be00507f15df0ffaccafec1dae9
      https://github.com/llvm/llvm-project/commit/3b8ae1001f678be00507f15df0ffaccafec1dae9
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2020-07-04 (Sat, 04 Jul 2020)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
    M llvm/test/Transforms/InstCombine/icmp-mul-zext.ll

  Log Message:
  -----------
  [InstCombine] fix miscompile from umul_with_overflow matching

As noted in PR46561:
https://bugs.llvm.org/show_bug.cgi?id=46561
...it takes something beyond a minimal IR example to trigger
this bug because it relies on matching non-canonical IR.

There are no tests that show the need for matching this
pattern, so I'm just deleting it to fix the miscompile.




More information about the All-commits mailing list