[all-commits] [llvm/llvm-project] ef70cc: [InstCombine] improve debug value names; NFC

RotateRight via All-commits all-commits at lists.llvm.org
Sat Jul 4 08:06:52 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ef70cc9d1ac69125f38910d4c66388536f49f4dc
      https://github.com/llvm/llvm-project/commit/ef70cc9d1ac69125f38910d4c66388536f49f4dc
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2020-07-04 (Sat, 04 Jul 2020)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
    M llvm/test/Transforms/InstCombine/icmp-mul-zext.ll
    M llvm/test/Transforms/InstCombine/phi.ll

  Log Message:
  -----------
  [InstCombine] improve debug value names; NFC

The use of 'tmp' can trigger warnings from the update_test_checks.py
script. That's evidence of a flaw in the script's logic, but we
can always do better than naming variables 'tmp' in LLVM too.

The phi test file should be updated with auto-generated regex CHECK
lines, so it isn't affected by cosmetic diffs, but I don't have
time to do that right now.




More information about the All-commits mailing list