[all-commits] [llvm/llvm-project] 769af9: [llvm-readelf] - Do not report a misleading warnin...

Georgii Rymar via All-commits all-commits at lists.llvm.org
Fri Jul 3 02:02:41 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 769af95e657dd7831e88a37fbb60f5cd2b24abdd
      https://github.com/llvm/llvm-project/commit/769af95e657dd7831e88a37fbb60f5cd2b24abdd
  Author: Georgii Rymar <grimar at accesssoftek.com>
  Date:   2020-07-03 (Fri, 03 Jul 2020)

  Changed paths:
    M llvm/test/tools/llvm-readobj/ELF/symbols.test
    M llvm/tools/llvm-readobj/ELFDumper.cpp

  Log Message:
  -----------
  [llvm-readelf] - Do not report a misleading warning when there is no string table.

This is a follow-up for D82955, which allows to continue dumping when a symbol table is broken.
When we are unable to get the string table and trying to print symbols,
the existent tool logic together with D82955 reports an error:

"st_name (0x??) is past the end of the string table of size 0x??"

Though, when there is no string table, this message becomes misleading and excessive.
It is easy to fix it though and that is what this patch does.

Differential revision: https://reviews.llvm.org/D83042




More information about the All-commits mailing list