[all-commits] [llvm/llvm-project] d6343e: [lldb] Skip TestLimitDebugInfo on windows

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d6343e607ac8fa71fa6d99f9c86369ae9e66e671
      https://github.com/llvm/llvm-project/commit/d6343e607ac8fa71fa6d99f9c86369ae9e66e671
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-07-02 (Thu, 02 Jul 2020)

  Changed paths:
    M lldb/test/API/functionalities/limit-debug-info/Makefile
    M lldb/test/API/functionalities/limit-debug-info/TestLimitDebugInfo.py
    M lldb/test/API/functionalities/limit-debug-info/onetwo.h

  Log Message:
  -----------
  [lldb] Skip TestLimitDebugInfo on windows

The test does not work on windows, because clang will emit full type
information for __declspec(dllexport) types even under
-flimit-debug-info. __declspec(dllexport) is needed to be able to use
the type across shared library boundaries on windows, which makes this a
pretty good heuristic, but defeats the purpose of this test.

I am going to create (in another patch) an basic assembly test, so that
the relevant code gets at least some coverage on windows hosts.

This also reverts commit 1276855f2b4485ec312b379c1b8eaf5510d9b157, which
added the __declspec annotations -- they are not necessary anymore, and
they needlessly complicate the test.