[all-commits] [llvm/llvm-project] 9010ce: [lldb] Replace StringConvert with llvm::to_integer...

[Raphael Isemann via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9010cef2af0affdef774a721f6adb52a40041da5
      https://github.com/llvm/llvm-project/commit/9010cef2af0affdef774a721f6adb52a40041da5
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-07-01 (Wed, 01 Jul 2020)

  Changed paths:
    M lldb/source/Commands/CommandObjectFrame.cpp
    M lldb/source/Commands/CommandObjectPlatform.cpp
    M lldb/source/Commands/CommandObjectProcess.cpp
    M lldb/source/Commands/CommandObjectTarget.cpp
    M lldb/source/Commands/CommandObjectThread.cpp
    M lldb/test/API/commands/frame/recognizer/TestFrameRecognizer.py
    A lldb/test/API/commands/platform/file/close/TestPlatformFileClose.py
    A lldb/test/API/commands/platform/file/read/TestPlatformFileRead.py
    A lldb/test/API/commands/process/signal/Makefile
    A lldb/test/API/commands/process/signal/TestProcessSignal.py
    A lldb/test/API/commands/process/signal/main.cpp
    A lldb/test/API/commands/target/modules/search-paths/insert/Makefile
    A lldb/test/API/commands/target/modules/search-paths/insert/TestTargetModulesSearchpathsInsert.py
    A lldb/test/API/commands/target/modules/search-paths/insert/main.cpp
    A lldb/test/API/commands/target/select/TestTargetSelect.py
    A lldb/test/API/commands/target/stop-hook/delete/TestTargetStopHookDelete.py
    A lldb/test/API/commands/target/stop-hook/disable/TestTargetStopHookDisable.py
    A lldb/test/API/commands/target/stop-hook/enable/TestTargetStopHookEnable.py
    A lldb/test/API/commands/thread/select/Makefile
    A lldb/test/API/commands/thread/select/TestThreadSelect.py
    A lldb/test/API/commands/thread/select/main.cpp

  Log Message:
  -----------
  [lldb] Replace StringConvert with llvm::to_integer when parsing integer values in CommandObjects

Summary:

This replaces the current use of LLDB's own `StringConvert` with LLVM's
`to_integer` which has a less error-prone API and doesn't use special 'error
values' to designate parsing problems.

Where needed I also added missing error handling code that prints a parsing
error instead of continuing with the error value returned from `StringConvert`
(which either gave a cryptic error message or just took the error value
performed an incorrect action with it. For example, `frame recognizer delete -1`
just deleted the frame recognizer at index 0).

Reviewers: #lldb, labath

Reviewed By: labath

Subscribers: labath, abidh, JDevlieghere

Differential Revision: https://reviews.llvm.org/D82297