[all-commits] [llvm/llvm-project] a61f62: Revert "[lldb/api] Improve error reporting in SBBr...

[Med Ismail Bennani via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a61f62a7b605a9077672b4f49021d84ed0cf12d9
      https://github.com/llvm/llvm-project/commit/a61f62a7b605a9077672b4f49021d84ed0cf12d9
  Author: Med Ismail Bennani <medismail.bennani at gmail.com>
  Date:   2020-07-01 (Wed, 01 Jul 2020)

  Changed paths:
    M lldb/bindings/interface/SBBreakpoint.i
    M lldb/include/lldb/API/SBBreakpoint.h
    M lldb/source/API/SBBreakpoint.cpp
    M lldb/test/API/functionalities/breakpoint/breakpoint_names/TestBreakpointNames.py

  Log Message:
  -----------
  Revert "[lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI)"

This reverts commit 56bb1d1755ae38b4e7a67f775978b18a601f215f.


  Commit: f70cad26121543c0a29b9a2c400b02c659210d71
      https://github.com/llvm/llvm-project/commit/f70cad26121543c0a29b9a2c400b02c659210d71
  Author: Med Ismail Bennani <medismail.bennani at gmail.com>
  Date:   2020-07-01 (Wed, 01 Jul 2020)

  Changed paths:
    M lldb/bindings/interface/SBBreakpoint.i
    M lldb/include/lldb/API/SBBreakpoint.h
    M lldb/source/API/SBBreakpoint.cpp
    M lldb/test/API/functionalities/breakpoint/breakpoint_names/TestBreakpointNames.py

  Log Message:
  -----------
  [lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI)

This patch improves the error reporting for SBBreakpoint::AddName by
adding a new method `SBBreakpoint::AddNameWithErrorHandling` that returns
a SBError instead of a boolean.

This way, if the breakpoint naming failed in the backend, the client
(i.e. Xcode), will be able to report the reason of that failure to the
user.

rdar://64765461

Differential Revision: https://reviews.llvm.org/D82879

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>


Compare: https://github.com/llvm/llvm-project/compare/56bb1d1755ae...f70cad261215