[all-commits] [llvm/llvm-project] 154401: [IR] Delete llvm::Constants using the correct type.

[Eli Friedman via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 15440191b57237eafb18600ac653b9a0023db391
      https://github.com/llvm/llvm-project/commit/15440191b57237eafb18600ac653b9a0023db391
  Author: Eli Friedman <efriedma at quicinc.com>
  Date:   2020-06-30 (Tue, 30 Jun 2020)

  Changed paths:
    M llvm/include/llvm/IR/Constant.h
    M llvm/include/llvm/IR/Constants.h
    M llvm/lib/Bitcode/Reader/ValueList.cpp
    M llvm/lib/IR/Constants.cpp
    M llvm/lib/IR/ConstantsContext.h
    M llvm/lib/IR/Value.cpp

  Log Message:
  -----------
  [IR] Delete llvm::Constants using the correct type.

In most cases, this doesn't have much impact: the destructors just call
the base class destructor anyway.  A few subclasses of ConstantExpr
actually store non-trivial data, though. Make sure we clean up
appropriately.

This is sort of ugly, but I don't see a good alternative given the
constraints.

Issue found by asan buildbots running the testcase for D80330.

Differential Revision: https://reviews.llvm.org/D82509