[all-commits] [llvm/llvm-project] 39ea5d: Revert "Fix missing build dependency on omp_gen."

Simon Tatham via All-commits all-commits at lists.llvm.org
Tue Jun 30 01:38:20 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 39ea5d74b283d5a42f34b856d22bfaf806a1c907
      https://github.com/llvm/llvm-project/commit/39ea5d74b283d5a42f34b856d22bfaf806a1c907
  Author: Simon Tatham <simon.tatham at arm.com>
  Date:   2020-06-30 (Tue, 30 Jun 2020)

  Changed paths:
    M llvm/include/llvm/CMakeLists.txt
    M llvm/include/llvm/Frontend/OpenMP/CMakeLists.txt

  Log Message:
  -----------
  Revert "Fix missing build dependency on omp_gen."

This reverts commit ed4328c607306a2aa6df4833a0dce4482edbc94c.

My change apparently caused a buildbot to fail with the error

  CMake Error at /b/sanitizer-x86_64-linux-autoconf/build/tsan_release_build/lib/cmake/llvm/AddLLVM.cmake:869 (add_dependencies):
  The dependency target "omp_gen" of target "ScudoBenchmarks.x86_64" does not
  exist.

I don't at all understand why, because as far as I can see, the target
`omp_gen` is only added to `LLVM_COMMON_DEPENDS` after having been
created, so there //should// be no way it can end up on anything's
dependency list if it doesn't exist! But apparently it happened anyway.

Differential Revision: https://reviews.llvm.org/D82659




More information about the All-commits mailing list