[all-commits] [llvm/llvm-project] 632438: [FileCheck][NFC] Clean up RUN style in verbose.txt...

Joel E. Denny via All-commits all-commits at lists.llvm.org
Mon Jun 29 15:37:05 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 632438726429859b80a68721bf91daec2d8b7b2a
      https://github.com/llvm/llvm-project/commit/632438726429859b80a68721bf91daec2d8b7b2a
  Author: Joel E. Denny <jdenny.ornl at gmail.com>
  Date:   2020-06-29 (Mon, 29 Jun 2020)

  Changed paths:
    M llvm/test/FileCheck/verbose.txt

  Log Message:
  -----------
  [FileCheck][NFC] Clean up RUN style in verbose.txt test

Reviewed By: jhenderson, thopre

Differential Revision: https://reviews.llvm.org/D82658


  Commit: 782585a2144e2af019bd3e4dc48cab611545645b
      https://github.com/llvm/llvm-project/commit/782585a2144e2af019bd3e4dc48cab611545645b
  Author: Joel E. Denny <jdenny.ornl at gmail.com>
  Date:   2020-06-29 (Mon, 29 Jun 2020)

  Changed paths:
    M llvm/test/FileCheck/verbose.txt
    M llvm/utils/FileCheck/FileCheck.cpp

  Log Message:
  -----------
  [FileCheck] Permit multiple -v or -vv

`FILECHECK_OPTS` was implemented so that a test runner, such as CI,
can specify FileCheck debugging options, such as `-v` and `-vv`.
However, if a test suite has a FileCheck call that already specifies
`-v` or `-vv`, then that call will fail if `FILECHECK_OPTS` also
specifies it.

For `-vv`, this problem already exists:

`clang/test/CodeGen/aarch64-v8.2a-fp16-intrinsics-constrained.c`

It's not yet clear if the `-vv` in that test was intentional, but this
usage shouldn't fail anyway.  It's already true that FileCheck permits
`-vv` and `-v` together even though `-vv` implies `-v`.

Compare D70784, which fixed the same problem for `-dump-input`.

Reviewed By: jhenderson, thopre

Differential Revision: https://reviews.llvm.org/D82601


Compare: https://github.com/llvm/llvm-project/compare/4772b99dffec...782585a2144e


More information about the All-commits mailing list