[all-commits] [llvm/llvm-project] 657ac8: [CMake] Fix incorrect handling of get_target_prope...

Christopher Tetreault via All-commits all-commits at lists.llvm.org
Mon Jun 29 14:46:20 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 657ac8e717e3cbb121e424c0cb6e2cffdacfd533
      https://github.com/llvm/llvm-project/commit/657ac8e717e3cbb121e424c0cb6e2cffdacfd533
  Author: Christopher Tetreault <ctetreau at quicinc.com>
  Date:   2020-06-29 (Mon, 29 Jun 2020)

  Changed paths:
    M llvm/cmake/modules/AddLLVM.cmake

  Log Message:
  -----------
  [CMake] Fix incorrect handling of get_target_property failure

Summary:
add_unittest was checking that the result of get_target_property was not
"NOTFOUND", but despite what the documentation says, get_target_property
returns <the var>-NOTFOUND on failure.

Reviewers: efriedma, thakis, serge-sans-paille, chandlerc

Reviewed By: serge-sans-paille

Subscribers: mgorny, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D81762




More information about the All-commits mailing list