[all-commits] [llvm/llvm-project] 8cce7a: [SourceManager] don't check invalid param of getLo...

Nick Desaulniers via All-commits all-commits at lists.llvm.org
Fri Jun 26 10:22:54 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8cce7af090bd011f6371dec34dfcab494cc74c46
      https://github.com/llvm/llvm-project/commit/8cce7af090bd011f6371dec34dfcab494cc74c46
  Author: Nick Desaulniers <ndesaulniers at google.com>
  Date:   2020-06-26 (Fri, 26 Jun 2020)

  Changed paths:
    M clang/include/clang/Basic/SourceManager.h
    M clang/lib/Basic/SourceManager.cpp

  Log Message:
  -----------
  [SourceManager] don't check invalid param of getLocalSLocEntry()

Forked from D80681.

getLocalSLocEntry() has an unused parameter used to satisfy an interface
of libclang (see getInclusions() in
clang/tools/libclang/CIndexInclusionStack.cpp).  It's pointless for
callers to construct/pass/check this inout parameter that can never
signify that a FileID is invalid.

Reviewed By: kadircet

Differential Revision: https://reviews.llvm.org/D82498




More information about the All-commits mailing list