[all-commits] [llvm/llvm-project] 05c552: [libc++] Fix the runtimes build after making __con...

Louis Dionne via All-commits all-commits at lists.llvm.org
Thu Jun 25 22:27:40 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 05c552ad0535f0f7c871bdd41aed02144e27afd7
      https://github.com/llvm/llvm-project/commit/05c552ad0535f0f7c871bdd41aed02144e27afd7
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-06-26 (Fri, 26 Jun 2020)

  Changed paths:
    M libcxx/CMakeLists.txt
    M libcxx/include/CMakeLists.txt
    M llvm/runtimes/CMakeLists.txt

  Log Message:
  -----------
  [libc++] Fix the runtimes build after making __config_site mandatory

The runtimes build includes libcxx/include/CMakeLists.txt directly instead
of going through the top-level CMake file. This not-very-hygienic inclusion
caused some variables like LIBCXX_BINARY_DIR not to be defined properly,
and the config_site generation logic to fail after landing 53623d4aa710.

This patch works around this issue by defining the missing variables.
However, the proper fix for this would be for the runtimes build to
always go through libc++'s top-level CMakeLists.txt. Doing otherwise
is unsupported.




More information about the All-commits mailing list