[all-commits] [llvm/llvm-project] 8938a6: [NFC] update test to make diff of the following co...

Tobias Bosch via All-commits all-commits at lists.llvm.org
Thu Jun 25 14:27:29 PDT 2020


Added the correct email-address...

On Thu, Jun 25, 2020 at 2:15 PM Tobias Bosch <tbosch at google.com> wrote:

> Hello Tyker,
> we're seeing your commit c95ffadb2474a4d8c4f598d94d35a9f31d9606cb having
> caused problems with miscompiles in a testcase. Would you mind reverting
> this temporarily and I'll try to get you a testcase?
>
> Thanks!
>
> --Tobi
>
>
> On Thu, Jun 25, 2020 at 4:00 AM Ralender via All-commits <
> all-commits at lists.llvm.org> wrote:
>
>>   Branch: refs/heads/master
>>   Home:   https://github.com/llvm/llvm-project
>>   Commit: 8938a6c9ede29a2d738357c44d66a017d74fcc7e
>>
>> https://github.com/llvm/llvm-project/commit/8938a6c9ede29a2d738357c44d66a017d74fcc7e
>>   Author: Tyker <tyker1 at outlook.com>
>>   Date:   2020-06-25 (Thu, 25 Jun 2020)
>>
>>   Changed paths:
>>     M clang/test/CodeGen/align_value.cpp
>>     M clang/test/CodeGen/alloc-align-attr.c
>>     M clang/test/CodeGen/builtin-align.c
>>     M clang/test/CodeGen/builtin-assume-aligned.c
>>     M llvm/test/Transforms/AlignmentFromAssumptions/simple32.ll
>>     M llvm/test/Transforms/Inline/align.ll
>>
>>   Log Message:
>>   -----------
>>   [NFC] update test to make diff of the following commit clear
>>
>>
>>   Commit: c95ffadb2474a4d8c4f598d94d35a9f31d9606cb
>>
>> https://github.com/llvm/llvm-project/commit/c95ffadb2474a4d8c4f598d94d35a9f31d9606cb
>>   Author: Tyker <tyker1 at outlook.com>
>>   Date:   2020-06-25 (Thu, 25 Jun 2020)
>>
>>   Changed paths:
>>     M clang/lib/CodeGen/CodeGenFunction.cpp
>>     M clang/test/CodeGen/align_value.cpp
>>     M clang/test/CodeGen/alloc-align-attr.c
>>     M clang/test/CodeGen/assume-aligned-and-alloc-align-attributes.c
>>     M clang/test/CodeGen/builtin-align-array.c
>>     M clang/test/CodeGen/builtin-align.c
>>     M clang/test/CodeGen/builtin-assume-aligned.c
>>     M
>> clang/test/CodeGen/catch-alignment-assumption-attribute-align_value-on-lvalue.cpp
>>     M
>> clang/test/CodeGen/catch-alignment-assumption-attribute-align_value-on-paramvar.cpp
>>     M
>> clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp
>>     M
>> clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function.cpp
>>     M
>> clang/test/CodeGen/catch-alignment-assumption-attribute-assume_aligned-on-function-two-params.cpp
>>     M
>> clang/test/CodeGen/catch-alignment-assumption-attribute-assume_aligned-on-function.cpp
>>     M
>> clang/test/CodeGen/catch-alignment-assumption-builtin_assume_aligned-three-params-variable.cpp
>>     M
>> clang/test/CodeGen/catch-alignment-assumption-builtin_assume_aligned-three-params.cpp
>>     M
>> clang/test/CodeGen/catch-alignment-assumption-builtin_assume_aligned-two-params.cpp
>>     M clang/test/CodeGen/catch-alignment-assumption-openmp.cpp
>>     M clang/test/CodeGen/non-power-of-2-alignment-assumptions.c
>>     M clang/test/OpenMP/simd_codegen.cpp
>>     M clang/test/OpenMP/simd_metadata.c
>>     M
>> clang/test/OpenMP/target_teams_distribute_parallel_for_simd_codegen.cpp
>>     M llvm/include/llvm/IR/IRBuilder.h
>>     M llvm/lib/Analysis/AssumeBundleQueries.cpp
>>     M llvm/lib/IR/IRBuilder.cpp
>>     M llvm/lib/IR/Verifier.cpp
>>     M llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
>>     M llvm/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp
>>     M llvm/test/Transforms/AlignmentFromAssumptions/simple.ll
>>     M llvm/test/Transforms/AlignmentFromAssumptions/simple32.ll
>>     M llvm/test/Transforms/Inline/align.ll
>>     M llvm/test/Transforms/InstCombine/assume.ll
>>     M llvm/test/Transforms/PhaseOrdering/inlining-alignment-assumptions.ll
>>     M llvm/test/Verifier/assume-bundles.ll
>>     M llvm/unittests/Analysis/AssumeBundleQueriesTest.cpp
>>
>>   Log Message:
>>   -----------
>>   [AssumeBundles] Use operand bundles to encode alignment assumptions
>>
>> Summary:
>> NOTE: There is a mailing list discussion on this:
>> http://lists.llvm.org/pipermail/llvm-dev/2019-December/137632.html
>>
>> Complemantary to the assumption outliner prototype in D71692, this patch
>> shows how we could simplify the code emitted for an alignemnt
>> assumption. The generated code is smaller, less fragile, and it makes it
>> easier to recognize the additional use as a "assumption use".
>>
>> As mentioned in D71692 and on the mailing list, we could adopt this
>> scheme, and similar schemes for other patterns, without adopting the
>> assumption outlining.
>>
>> Reviewers: hfinkel, xbolva00, lebedev.ri, nikic, rjmccall, spatel,
>> jdoerfert, sstefan1
>>
>> Reviewed By: jdoerfert
>>
>> Subscribers: yamauchi, kuter, fhahn, merge_guards_bot, hiraditya, bollu,
>> rkruppe, cfe-commits, llvm-commits
>>
>> Tags: #clang, #llvm
>>
>> Differential Revision: https://reviews.llvm.org/D71739
>>
>>
>> Compare:
>> https://github.com/llvm/llvm-project/compare/043b60839955...c95ffadb2474
>> _______________________________________________
>> All-commits mailing list
>> All-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/all-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/all-commits/attachments/20200625/a1e63b50/attachment.html>


More information about the All-commits mailing list