[all-commits] [llvm/llvm-project] c61ef1: [Sema][CodeComplete][ObjC] Don't split the first s...

David Goldman via All-commits all-commits at lists.llvm.org
Thu Jun 25 10:59:28 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c61ef1f25c7fe774e68d20beb956a3b12a353b95
      https://github.com/llvm/llvm-project/commit/c61ef1f25c7fe774e68d20beb956a3b12a353b95
  Author: David Goldman <davg at google.com>
  Date:   2020-06-25 (Thu, 25 Jun 2020)

  Changed paths:
    M clang/lib/Sema/SemaCodeComplete.cpp
    M clang/test/Index/complete-method-decls.m
    M clang/test/Index/complete-parameterized-classes.m

  Log Message:
  -----------
  [Sema][CodeComplete][ObjC] Don't split the first selector fragment

Summary:
Standardize the formatting of selector fragments to include the ':',
e.g. for `- (void)foobar:(int)foobar;`, report `{foobar:}` instead of
`{foobar}{:}`. This was normally the case except for a couple of places
where it was split.

This also improves integration with clangd since it relies upon the `:`
to identify ObjC selectors.

NOTE: It is possible to have selector fragments that are just `:` with
no text, we now handle this properly for the first fragment.

Reviewers: sammccall, doug.gregor

Subscribers: ilya-biryukov, dexonsmith, arphaman, kadircet, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D82306




More information about the All-commits mailing list