[all-commits] [llvm/llvm-project] f8bd6a: [SimplifyCFG] Drop debug loc in SpeculativelyExecu...

Vedant Kumar via All-commits all-commits at lists.llvm.org
Tue Jun 23 18:26:37 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f8bd6a75edac7560deb5fdcb31041b454dd9d7e0
      https://github.com/llvm/llvm-project/commit/f8bd6a75edac7560deb5fdcb31041b454dd9d7e0
  Author: Vedant Kumar <vsk at apple.com>
  Date:   2020-06-23 (Tue, 23 Jun 2020)

  Changed paths:
    M llvm/lib/Transforms/Utils/SimplifyCFG.cpp
    A llvm/test/Transforms/SimplifyCFG/drop-debug-loc-when-speculating.ll

  Log Message:
  -----------
  [SimplifyCFG] Drop debug loc in SpeculativelyExecuteBB

Summary:
According to HowToUpdateDebugInfo.rst:

```
Preserving the debug locations of speculated instructions can make
it seem like a condition is true when it's not (or vice versa), which
leads to a confusing single-stepping experience
```

This patch follows the recommendation to drop debug locations on
speculated instructions.

Reviewers: aprantl, davide

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D82420




More information about the All-commits mailing list