[all-commits] [llvm/llvm-project] 28a671: [ManagedStatic] Fix build errors with clang-tblgen...

Denys Petrov via All-commits all-commits at lists.llvm.org
Tue Jun 23 15:55:57 PDT 2020


  Branch: refs/heads/release/10.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 28a6713e107c9f878cb6c59db8548bb732dcc79d
      https://github.com/llvm/llvm-project/commit/28a6713e107c9f878cb6c59db8548bb732dcc79d
  Author: Denys Petrov <dpetrov at accesssoftek.com>
  Date:   2020-06-23 (Tue, 23 Jun 2020)

  Changed paths:
    M llvm/include/llvm/Support/ManagedStatic.h

  Log Message:
  -----------
  [ManagedStatic] Fix build errors with clang-tblgen in Debug mode using MSVC 2019 v16.6

After updating MSVS19 from v16.4 to v16.6 I faced with a build errors compiling in Debug mode.
It complains on clang-tblgen.exe and llvm-tblgen.exe cmd line args.
VS compiler had a bug. It dynamically creates an object with constexpr ctor in Debug mode. This bug was fixed in VS2019 v16.5.
A workaround was implemented for that and everything works until v16.5 comes.
The workaround became irrelevant since v16.5 and caused build errors.
So I disabled the workaround for VS2019 v16.5 and higher.

This relates to http://llvm.org/PR41367.

Differential Revision: https://reviews.llvm.org/D80433

(cherry picked from commit 46e5c5fe778b92b2a7e2c2ad3610e1da6794bd5e)




More information about the All-commits mailing list