[all-commits] [llvm/llvm-project] 6904c7: [IR] Remove MSVC warning workaround (NFC)

Nikita Popov via All-commits all-commits at lists.llvm.org
Tue Jun 23 13:34:20 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6904c7129b26373eb33489b43538ab580829655e
      https://github.com/llvm/llvm-project/commit/6904c7129b26373eb33489b43538ab580829655e
  Author: Nikita Popov <nikita.ppv at gmail.com>
  Date:   2020-06-23 (Tue, 23 Jun 2020)

  Changed paths:
    M llvm/lib/IR/Attributes.cpp

  Log Message:
  -----------
  [IR] Remove MSVC warning workaround (NFC)

While LLVM does fold this to x+1, GCC does not. As this is hot
code, let's try to avoid that.

According to
https://developercommunity.visualstudio.com/content/problem/211134/unsigned-integer-overflows-in-constexpr-functionsa.html
this spurious warning in MSVC has been fixed in Visual Studio 2019
Version 16.4. Let's see if there are any build bots running old
MSVC versions with warnings treated as errors...




More information about the All-commits mailing list