[all-commits] [llvm/llvm-project] 0a9e7d: [vscode] set default values for terminateDebuggee ...

[walter erquinigo via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0a9e7d0b6befad866dfd61f05b774247e0867121
      https://github.com/llvm/llvm-project/commit/0a9e7d0b6befad866dfd61f05b774247e0867121
  Author: Walter Erquinigo <waltermelon at fb.com>
  Date:   2020-06-23 (Tue, 23 Jun 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
    A lldb/test/API/tools/lldb-vscode/disconnect/Makefile
    A lldb/test/API/tools/lldb-vscode/disconnect/TestVSCode_disconnect.py
    A lldb/test/API/tools/lldb-vscode/disconnect/main.cpp
    M lldb/tools/lldb-vscode/VSCode.cpp
    M lldb/tools/lldb-vscode/VSCode.h
    M lldb/tools/lldb-vscode/lldb-vscode.cpp

  Log Message:
  -----------
  [vscode] set default values for terminateDebuggee for the disconnect request

Summary:
Recently I've noticed that VSCode sometimes doesn't send the terminateDebuggee flag within the disconnectRequest,
even though lldb-vscode sets the terminateDebuggee capability correctly.
This has been causing that inferiors don't die after the debug session ends, and many users have reported issues because of this.

An easy way to mitigate this is to set better default values for the terminateDebuggee field in the disconnect request.
I'm assuming that for a launch request, the default will be true, and for attach it'll be false.

Reviewers: clayborg, labath, aadsm

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D81200