[all-commits] [llvm/llvm-project] ef3adb: [clang][NFC] Fix typos/wording in the comments of ...

[Bruno Ricci via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ef3adbfc70bd593e14430c2db31c1426d3834fb4
      https://github.com/llvm/llvm-project/commit/ef3adbfc70bd593e14430c2db31c1426d3834fb4
  Author: Bruno Ricci <riccibrun at gmail.com>
  Date:   2020-06-21 (Sun, 21 Jun 2020)

  Changed paths:
    M clang/include/clang/AST/Expr.h
    M clang/include/clang/AST/Stmt.h

  Log Message:
  -----------
  [clang][NFC] Fix typos/wording in the comments of ConstantExpr.

It is "trailing objects" and "tail-allocated storage".


  Commit: e7ce0528202306d8b751f132d9d3a6519ce4e688
      https://github.com/llvm/llvm-project/commit/e7ce0528202306d8b751f132d9d3a6519ce4e688
  Author: Bruno Ricci <riccibrun at gmail.com>
  Date:   2020-06-21 (Sun, 21 Jun 2020)

  Changed paths:
    M clang/include/clang/AST/Expr.h
    M clang/include/clang/AST/Stmt.h
    M clang/lib/AST/Expr.cpp
    M clang/lib/Serialization/ASTReaderStmt.cpp
    M clang/lib/Serialization/ASTWriterStmt.cpp
    A clang/test/AST/ast-dump-constant-expr.cpp

  Log Message:
  -----------
  [clang][Serialization] Fix the serialization of ConstantExpr.

The serialization of ConstantExpr has currently a number of problems:

- Some fields are just not serialized (ConstantExprBits.APValueKind and
  ConstantExprBits.IsImmediateInvocation).

- ASTStmtReader::VisitConstantExpr forgets to add the trailing APValue
  to the list of objects to be destroyed when the APValue needs cleanup.

While we are at it, bring the serialization of ConstantExpr more in-line
with what is done with the other expressions by doing the following NFCs:

- Get rid of ConstantExpr::DefaultInit. It is better to not initialize
  the fields of an empty ConstantExpr since this will allow msan to
  detect if a field was not deserialized.

- Move the initialization of the fields of ConstantExpr to the constructor;
  ConstantExpr::Create allocates the memory and ConstantExpr::ConstantExpr
  is responsible for the initialization.

Review after commit since this is a straightforward mechanical fix
similar to the other serialization fixes.


  Commit: 0dbeffddd1decda612f00e552c35cbcdb59907ab
      https://github.com/llvm/llvm-project/commit/0dbeffddd1decda612f00e552c35cbcdb59907ab
  Author: Bruno Ricci <riccibrun at gmail.com>
  Date:   2020-06-21 (Sun, 21 Jun 2020)

  Changed paths:
    M clang/utils/make-ast-dump-check.sh

  Log Message:
  -----------
  [clang][utils] Minor tweak to make-ast-dump-check.sh

Remove the space after the "CHECK:" on each line. This space makes the use
of FileCheck --match-full-lines impossible.


  Commit: e560280cd5739503cd9a75e05da769a6742918b5
      https://github.com/llvm/llvm-project/commit/e560280cd5739503cd9a75e05da769a6742918b5
  Author: Bruno Ricci <riccibrun at gmail.com>
  Date:   2020-06-21 (Sun, 21 Jun 2020)

  Changed paths:
    M clang/test/AST/ast-dump-lambda.cpp

  Log Message:
  -----------
  [clang][NFC] Regenerate test/AST/ast-dump-lambda.cpp with --match-full-lines.


  Commit: ecbf2f5f3d2e2868c6059320c185897f8f23de41
      https://github.com/llvm/llvm-project/commit/ecbf2f5f3d2e2868c6059320c185897f8f23de41
  Author: Bruno Ricci <riccibrun at gmail.com>
  Date:   2020-06-21 (Sun, 21 Jun 2020)

  Changed paths:
    M clang/test/AST/address_space_attribute.cpp
    M clang/test/AST/alignas_maybe_odr_cleanup.cpp
    M clang/test/AST/ast-dump-aarch64-sve-types.c
    M clang/test/AST/ast-dump-arm-attr.c
    M clang/test/AST/ast-dump-array.cpp
    M clang/test/AST/ast-dump-attr.cpp
    M clang/test/AST/ast-dump-attr.m
    M clang/test/AST/ast-dump-c-attr.c
    M clang/test/AST/ast-dump-decl-stmts.cpp
    M clang/test/AST/ast-dump-decl.c
    M clang/test/AST/ast-dump-decl.cpp
    M clang/test/AST/ast-dump-decl.m
    M clang/test/AST/ast-dump-decl.mm
    M clang/test/AST/ast-dump-expr.c
    M clang/test/AST/ast-dump-expr.cpp
    M clang/test/AST/ast-dump-funcs.cpp
    M clang/test/AST/ast-dump-msp430-attr.c

  Log Message:
  -----------
  [clang][test][NFC] Also test for serialization in AST dump tests, part 2/n.

The outputs between the direct ast-dump test and the ast-dump test after
deserialization should match modulo a few differences.

For hand-written tests, strip the "<undeserialized declarations>"s and
the "imported"s with sed.

For tests generated with "make-ast-dump-check.sh", regenerate the
output.

Part 2/n.


  Commit: cddc9993eafd76f08989beea037d085521d48127
      https://github.com/llvm/llvm-project/commit/cddc9993eafd76f08989beea037d085521d48127
  Author: Bruno Ricci <riccibrun at gmail.com>
  Date:   2020-06-21 (Sun, 21 Jun 2020)

  Changed paths:
    M clang/test/AST/atomic-expr.cpp
    M clang/test/AST/c-casts.c
    M clang/test/AST/category-attribute.m
    M clang/test/AST/coroutine-source-location-crash.cpp
    M clang/test/AST/deduction-guides.cpp
    M clang/test/AST/fixed_point.c
    M clang/test/AST/fixed_point_to_string.c
    M clang/test/AST/float16.cpp
    M clang/test/AST/implicit-cast-dump.c
    M clang/test/AST/language_address_space_attribute.cpp
    M clang/test/AST/multistep-explicit-cast.c
    M clang/test/AST/multistep-explicit-cast.cpp
    M clang/test/AST/pr43983.cpp
    M clang/test/AST/property-atomic-bool.m
    M clang/test/AST/template-implicit-vars.cpp
    M clang/test/AST/variadic-promotion.c

  Log Message:
  -----------
  [clang][test][NFC] Also test for serialization in AST dump tests, part 3/n.

The outputs between the direct ast-dump test and the ast-dump test after
deserialization should match modulo a few differences.

For hand-written tests, strip the "<undeserialized declarations>"s and
the "imported"s with sed.

For tests generated with "make-ast-dump-check.sh", regenerate the output.

Part 3/n.


Compare: https://github.com/llvm/llvm-project/compare/93a0f0e4fe76...cddc9993eafd