[all-commits] [llvm/llvm-project] 862719: [builtins] Fix typos in comments

Ryan Prichard via All-commits all-commits at lists.llvm.org
Fri Jun 19 16:13:13 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8627190f310774434350822e9cc80b72b4a041d4
      https://github.com/llvm/llvm-project/commit/8627190f310774434350822e9cc80b72b4a041d4
  Author: Ryan Prichard <rprichard at google.com>
  Date:   2020-06-19 (Fri, 19 Jun 2020)

  Changed paths:
    M compiler-rt/lib/builtins/i386/floatdidf.S
    M compiler-rt/lib/builtins/i386/floatdixf.S

  Log Message:
  -----------
  [builtins] Fix typos in comments

Differential Revision: https://reviews.llvm.org/D82146


  Commit: ac716c0cc42afc8a179751794da5c661a9ca3f30
      https://github.com/llvm/llvm-project/commit/ac716c0cc42afc8a179751794da5c661a9ca3f30
  Author: Ryan Prichard <rprichard at google.com>
  Date:   2020-06-19 (Fri, 19 Jun 2020)

  Changed paths:
    M compiler-rt/cmake/Modules/CompilerRTUtils.cmake

  Log Message:
  -----------
  [builtins][Android] Fix 386->686 adjustment

At this point in this code:
 - COMPILER_RT_DEFAULT_TARGET_TRIPLE is "i686-linux-android"
 - arch is "i386"

The get_compiler_rt_target function currently turns that into:

   i686-android-linux-android

The ${COMPILER_RT_OS_SUFFIX} is "-android" and redundant, so stop
adding it.

The get_compiler_rt_target() function is used for the
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR mode that isn't normally used with
Android.

Differential Revision: https://reviews.llvm.org/D82150


Compare: https://github.com/llvm/llvm-project/compare/d7fad626e9a5...ac716c0cc42a


More information about the All-commits mailing list