[all-commits] [llvm/llvm-project] f5eaa2: [lldb] Replace std::isprint/isspace with llvm's lo...

Raphael Isemann via All-commits all-commits at lists.llvm.org
Fri Jun 19 10:18:30 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f5eaa2afe2a9faa2d05ca46e006e770d17c32778
      https://github.com/llvm/llvm-project/commit/f5eaa2afe2a9faa2d05ca46e006e770d17c32778
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-06-19 (Fri, 19 Jun 2020)

  Changed paths:
    M lldb/include/lldb/Interpreter/Options.h
    M lldb/source/Core/DumpDataExtractor.cpp
    M lldb/source/Core/IOHandler.cpp
    M lldb/source/Core/IOHandlerCursesGUI.cpp
    M lldb/source/Interpreter/CommandInterpreter.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
    M lldb/source/Utility/Args.cpp
    M lldb/source/Utility/DataExtractor.cpp
    M lldb/source/Utility/Event.cpp
    M lldb/source/Utility/StringExtractor.cpp

  Log Message:
  -----------
  [lldb] Replace std::isprint/isspace with llvm's locale-independent version

Summary:
LLVM is using its own isPrint/isSpace implementation that doesn't change depending on the current locale. LLDB should do the same
to prevent that internal logic changes depending on the set locale.

Reviewers: JDevlieghere, labath, mib, totally_not_teemperor

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D82175




More information about the All-commits mailing list