[all-commits] [llvm/llvm-project] 7e825a: Repair support for launching ios/tv/watch simulato...

[adrian-prantl via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7e825abd5704ce28b166f9463d4bd304348fd2a9
      https://github.com/llvm/llvm-project/commit/7e825abd5704ce28b166f9463d4bd304348fd2a9
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2020-06-19 (Fri, 19 Jun 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/dotest.py
    M lldb/packages/Python/lldbsuite/test/dotest_args.py
    M lldb/packages/Python/lldbsuite/test/make/Makefile.rules
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
    M lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.mm
    M lldb/test/API/functionalities/fat_archives/Makefile
    M lldb/test/API/lang/objcxx/class-name-clash/Makefile
    M lldb/test/API/macosx/find-app-in-bundle/Makefile
    M lldb/test/API/macosx/find-app-in-bundle/TestFindAppInBundle.py
    M lldb/test/API/macosx/find-dsym/bundle-with-dot-in-filename/Makefile
    M lldb/test/API/macosx/find-dsym/bundle-with-dot-in-filename/TestBundleWithDotInFilename.py
    M lldb/test/API/macosx/find-dsym/deep-bundle/Makefile
    M lldb/test/API/macosx/find-dsym/deep-bundle/TestDeepBundle.py
    A lldb/test/API/macosx/simulator/Makefile
    A lldb/test/API/macosx/simulator/TestSimulatorPlatform.py
    A lldb/test/API/macosx/simulator/hello.c
    M lldb/test/API/macosx/universal/Makefile

  Log Message:
  -----------
  Repair support for launching ios/tv/watch simulator binaries through platform

and delete a bunch (but not all) redundant code. If you compare the remaining implementations of Platform*Simulator.cpp, there is still an obvious leftover cleanup task.

Specifically, this patch

- removes SDK initialization from dotest (there is equivalent but more
  complete code in Makefile.rules)

- make Platform*Simulator inherit the generic implementation of
  PlatformAppleSimulator (more can be done here)

- simplify the platform logic in Makefile.rules

- replace the custom SDK finding logic in Platform*Simulator with XcodeSDK

- adds a test for each supported simulator

Differential Revision: https://reviews.llvm.org/D81980