[all-commits] [llvm/llvm-project] cd2553: [FileCheck, unittest] Improve readability of Expre...

RoboTux via All-commits all-commits at lists.llvm.org
Fri Jun 19 06:47:39 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: cd2553de77f2c3206deaa261a15cc7520ff2ff56
      https://github.com/llvm/llvm-project/commit/cd2553de77f2c3206deaa261a15cc7520ff2ff56
  Author: Thomas Preud'homme <thomasp at graphcore.ai>
  Date:   2020-06-19 (Fri, 19 Jun 2020)

  Changed paths:
    M llvm/unittests/Support/FileCheckTest.cpp

  Log Message:
  -----------
  [FileCheck, unittest] Improve readability of ExpressionFormat

Summary:
Factor out repetetitive code into helper function and split massive
ExpressionFormat method test into separate test for each method,
removing dead code in passing. Also add a MinInt64 and MaxInt64 checks
when testing getMatchingString.

Reviewers: jhenderson, jdenny, probinson, grimar, arichardson

Reviewed By: jhenderson, grimar

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D82132




More information about the All-commits mailing list