[all-commits] [llvm/llvm-project] d2fcc5: [clangd] Drop usage of PreambleStatCache in scanPr...

[kadir çetinkaya via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d2fcc586223c522098df7a627e87a6a6c8381fbe
      https://github.com/llvm/llvm-project/commit/d2fcc586223c522098df7a627e87a6a6c8381fbe
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-06-19 (Fri, 19 Jun 2020)

  Changed paths:
    M clang-tools-extra/clangd/Preamble.cpp

  Log Message:
  -----------
  [clangd] Drop usage of PreambleStatCache in scanPreamble

Summary: It was used inside buildCompilerInvocation to speed up stats. But
preambleStatCache doesn't contain stat information performed while
building compiler invocation. So it was an unnecessary optimization.

Furthermore, buildCompilerInvocation in scanPreamble doesn't need to
find gcc installation, include paths and such, as it is only trying to
lex directives. Hence we are passing an empty FS to get rid of any
redundant IO.

Reviewers: sammccall

Subscribers: ilya-biryukov, javed.absar, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D81719