[all-commits] [llvm/llvm-project] 5c5ec9: [mlir] Remove EDSC LoopBuilder, derived classes an...

[ftynse via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5c5ec96bd2c52b33b610b39e9cb9f5412722e6ea
      https://github.com/llvm/llvm-project/commit/5c5ec96bd2c52b33b610b39e9cb9f5412722e6ea
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2020-06-19 (Fri, 19 Jun 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/Affine/EDSC/Builders.h
    M mlir/include/mlir/Dialect/Linalg/EDSC/Builders.h
    M mlir/include/mlir/Dialect/SCF/EDSC/Builders.h
    M mlir/include/mlir/EDSC/Builders.h
    M mlir/lib/Dialect/Affine/EDSC/Builders.cpp
    M mlir/lib/Dialect/Linalg/EDSC/Builders.cpp
    M mlir/lib/Dialect/SCF/EDSC/Builders.cpp
    M mlir/lib/EDSC/Builders.cpp

  Log Message:
  -----------
  [mlir] Remove EDSC LoopBuilder, derived classes and related functionality

Callback-based loop construction, with loop bodies being constructed during the
construction of the parent op using a function, is now fully supported by the
core infrastructure. This provides almost the same level of brevity as EDSC
LoopBuilder at less than 30% infrastructural code cost. Functional equivalents
compatible with EDSC ScopedContext are implemented on top of the main builders.
LoopBuilder and related functionality has been deprecated, remove it.

Differential Revision: https://reviews.llvm.org/D81874


  Commit: 0af2262df2eea1cf72537d04cdd2f5893d6bd7dd
      https://github.com/llvm/llvm-project/commit/0af2262df2eea1cf72537d04cdd2f5893d6bd7dd
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2020-06-19 (Fri, 19 Jun 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/StandardOps/EDSC/Intrinsics.h
    M mlir/include/mlir/EDSC/Builders.h
    M mlir/lib/Dialect/StandardOps/EDSC/Intrinsics.cpp
    M mlir/lib/EDSC/Builders.cpp

  Log Message:
  -----------
  [mlir] Remove EDSC BlockBuilder, BlockHandle and related functionality

Callback-based constructions of blocks where the body is populated in the same
function as the block creation is a natural extension of callback-based loop
construction. They provide more concise and simple APIs than EDSC BlockBuilder
at less than 20% infrastructural code cost, and are compatible with
ScopedContext. BlockBuilder, Blockhandle and related functionality has been
deprecated, remove them.

Differential Revision: https://reviews.llvm.org/D82015


  Commit: 63b7e1e4744513bd319583e920c2436a251e1127
      https://github.com/llvm/llvm-project/commit/63b7e1e4744513bd319583e920c2436a251e1127
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2020-06-19 (Fri, 19 Jun 2020)

  Changed paths:
    M mlir/include/mlir/EDSC/Builders.h

  Log Message:
  -----------
  [mlir] Remove EDSC NestedBuilder

All class derived from `edsc::NestedBuilder` in core MLIR have been replaced
with alternatives based on OpBuilder+callbacks. The *Builder EDSC
infrastructure has been deprecated. Remove edsc::NestedBuilder.

This completes the "structured builders" refactoring.

Differential Revision: https://reviews.llvm.org/D82128


Compare: https://github.com/llvm/llvm-project/compare/7edc7f6edbcb...63b7e1e47445