[all-commits] [llvm/llvm-project] a75e09: [mlir] Provide OpBuilder-based replacements for ed...

ftynse via All-commits all-commits at lists.llvm.org
Thu Jun 18 02:47:53 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a75e09372e7f8715f93013a03542acfbb046583a
      https://github.com/llvm/llvm-project/commit/a75e09372e7f8715f93013a03542acfbb046583a
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2020-06-18 (Thu, 18 Jun 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/Linalg/EDSC/Builders.h
    M mlir/include/mlir/Dialect/StandardOps/EDSC/Intrinsics.h
    M mlir/include/mlir/EDSC/Builders.h
    M mlir/lib/Dialect/Linalg/EDSC/Builders.cpp
    M mlir/lib/Dialect/StandardOps/EDSC/Intrinsics.cpp
    M mlir/lib/EDSC/Builders.cpp
    M mlir/test/EDSC/builder-api-test.cpp

  Log Message:
  -----------
  [mlir] Provide OpBuilder-based replacements for edsc::BlockBuilder

The ScopedBuilder class in EDSC is being gradually phased out in favor of core
OpBuilder-based helpers with callbacks. Provide helper functions that are
compatible with `edsc::ScopedContext` and can be used to create and populate
blocks using callbacks that take block arguments as callback arguments. This
removes the need for `edsc::BlockHandle`, forward-declaration of `Value`s used
for block arguments and the tag `edsc::Append` class, leading to noticable
reduction in the verbosity of the code using helper functions.

Remove "eager mode" construction tests that are only relevant to the
`BlockBuilder`-based approach.

`edsc::BlockHandle` and `edsc::BlockBuilder` are now deprecated and will be
removed soon.

Differential Revision: https://reviews.llvm.org/D82008




More information about the All-commits mailing list