[all-commits] [llvm/llvm-project] b3e77c: [SVE] Remove invalid calls to VectorType::getNumEl...

Christopher Tetreault via All-commits all-commits at lists.llvm.org
Tue Jun 16 14:16:41 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b3e77c6d55853eea5f5c32ec8a3510c0b0e438e1
      https://github.com/llvm/llvm-project/commit/b3e77c6d55853eea5f5c32ec8a3510c0b0e438e1
  Author: Christopher Tetreault <ctetreau at quicinc.com>
  Date:   2020-06-16 (Tue, 16 Jun 2020)

  Changed paths:
    M llvm/include/llvm/CodeGen/BasicTTIImpl.h

  Log Message:
  -----------
  [SVE] Remove invalid calls to VectorType::getNumElements from BasicTTIImpl

Summary:
Most of these operations are reasonable for scalable vectors. Due to
this, we have decided not to change the interface to specifically take
FixedVectorType despite the fact that the current implementations make
fixed width assumptions. Instead, we cast to FixedVectorType and assert
in the body. If a developer makes some change in the future that causes
one of these asserts to fire, they should either change their code or
make the function they are trying to call handle scalable vectors.

Reviewers: efriedma, samparker, RKSimon, craig.topper, sdesmalen, c-rhodes

Reviewed By: efriedma

Subscribers: tschuett, rkruppe, psnobl, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D81495




More information about the All-commits mailing list