[all-commits] [llvm/llvm-project] 28ebdf: [gicombiner] Allow generated CombinerHelpers to ha...

Daniel Sanders via All-commits all-commits at lists.llvm.org
Tue Jun 16 14:12:11 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 28ebdf1a02eb26f1fc539991e97b41510bfd031f
      https://github.com/llvm/llvm-project/commit/28ebdf1a02eb26f1fc539991e97b41510bfd031f
  Author: Daniel Sanders <daniel_l_sanders at apple.com>
  Date:   2020-06-16 (Tue, 16 Jun 2020)

  Changed paths:
    M llvm/include/llvm/Target/GlobalISel/Combine.td
    M llvm/utils/TableGen/GICombinerEmitter.cpp

  Log Message:
  -----------
  [gicombiner] Allow generated CombinerHelpers to have additional arguments

Summary:
This allows combiners to delegate to other helpers or depend
on additional information. It's not great as an overall
solution though as callers must provide the argument on every call, even for
static data like an additional helper. Another patch will follow to
support additional members of the generated combiner.

Reviewers: aditya_nandakumar, bogner, aemerson, paquette, volkan, arsenm

Reviewed By: aditya_nandakumar

Subscribers: wdng, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D81862




More information about the All-commits mailing list