[all-commits] [llvm/llvm-project] c87bf2: [MachineVerifier][GlobalISel] Check that branches ...

Dominik Montada via All-commits all-commits at lists.llvm.org
Mon Jun 15 02:17:31 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c87bf29149598d6dd24470fe3c22dbd40f215dcb
      https://github.com/llvm/llvm-project/commit/c87bf29149598d6dd24470fe3c22dbd40f215dcb
  Author: Dominik Montada <dominik.montada at hightec-rt.com>
  Date:   2020-06-15 (Mon, 15 Jun 2020)

  Changed paths:
    M llvm/include/llvm/Target/GenericOpcodes.td
    M llvm/lib/CodeGen/MachineVerifier.cpp
    M llvm/test/CodeGen/AArch64/GlobalISel/legalize-blockaddress.mir
    M llvm/test/CodeGen/AArch64/GlobalISel/select-blockaddress.mir
    A llvm/test/MachineVerifier/test_g_brindirect_is_indirect_branch.mir
    A llvm/test/MachineVerifier/test_g_brjt_is_indirect_branch.mir

  Log Message:
  -----------
  [MachineVerifier][GlobalISel] Check that branches have a MBB operand or are declared indirect. Add missing properties to G_BRJT, G_BRINDIRECT

Summary:
Teach MachineVerifier to check branches for MBB operands if they are not declared indirect.

Add `isBarrier`, `isIndirectBranch` to `G_BRINDIRECT` and `G_BRJT`.
Without these, `MachineInstr.isConditionalBranch()` was giving a
false-positive for those instructions.

Reviewers: aemerson, qcolombet, dsanders, arsenm

Reviewed By: dsanders

Subscribers: hiraditya, wdng, simoncook, s.egerton, arsenm, rovka, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D81587




More information about the All-commits mailing list