[all-commits] [llvm/llvm-project] 660429: [WebAssembly] WebAssembly doesn't support "protect...

[Dan Gohman via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 66042959590d6db9d2a12803a16476d4e3508f3f
      https://github.com/llvm/llvm-project/commit/66042959590d6db9d2a12803a16476d4e3508f3f
  Author: Dan Gohman <sunfish at mozilla.com>
  Date:   2020-06-12 (Fri, 12 Jun 2020)

  Changed paths:
    M clang/lib/Basic/Targets/WebAssembly.h
    M llvm/docs/ReleaseNotes.rst

  Log Message:
  -----------
  [WebAssembly] WebAssembly doesn't support "protected" visibility

Implement the `hasProtectedVisibility()` hook to indicate that, like
Darwin, WebAssembly doesn't support "protected" visibility.

On ELF, "protected" visibility is intended to be an optimization, however
in practice it often [isn't], and ELF documentation generally ranges from
[not mentioning it at all] to [strongly discouraging its use].

[isn't]: https://www.airs.com/blog/archives/307
[not mentioning it at all]: https://gcc.gnu.org/wiki/Visibility
[strongly discouraging its use]: https://www.akkadia.org/drepper/dsohowto.pdf

While here, also mention the new Reactor support in the release notes.