[all-commits] [llvm/llvm-project] 1727c6: [clang] Use IsVolatile=true and RequiresNullTermin...

Michael Spencer via All-commits all-commits at lists.llvm.org
Wed Jun 10 13:37:53 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1727c6aab34012f0cefc8a3f29ede5f1f718c832
      https://github.com/llvm/llvm-project/commit/1727c6aab34012f0cefc8a3f29ede5f1f718c832
  Author: Michael Spencer <bigcheesegs at gmail.com>
  Date:   2020-06-10 (Wed, 10 Jun 2020)

  Changed paths:
    M clang/lib/Serialization/ModuleManager.cpp

  Log Message:
  -----------
  [clang] Use IsVolatile=true and RequiresNullTerminator=false for PCMs

This change got missed while upstreaming
https://reviews.llvm.org/D77772. This is the part of that change that
actually passes the correct arguments when opening a PCM.

The test didn't catch this because it starts at the
`MemoryBuffer::getOpenFile` level. It's not really possible to test
`ModuleManager::addModule` itself to verify how the file was opened.




More information about the All-commits mailing list