[all-commits] [llvm/llvm-project] 601b8a: GlobalISel: Move LegalizerHelper members around

Matt Arsenault via All-commits all-commits at lists.llvm.org
Wed Jun 10 10:57:11 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 601b8a0dc9cd43a0a4c8efb90ec8dc5f62b4a882
      https://github.com/llvm/llvm-project/commit/601b8a0dc9cd43a0a4c8efb90ec8dc5f62b4a882
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-06-10 (Wed, 10 Jun 2020)

  Changed paths:
    M llvm/include/llvm/CodeGen/GlobalISel/LegalizerHelper.h

  Log Message:
  -----------
  GlobalISel: Move LegalizerHelper members around

MIRBuilder was in the middle of of a bunch of methods and not group
with the other member variables, which made it harder to see what
state this carries around. Move these to the top as is the usual
convention.


  Commit: 721f8f7530ec3b3f79c3a187fae177178a74c25c
      https://github.com/llvm/llvm-project/commit/721f8f7530ec3b3f79c3a187fae177178a74c25c
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-06-10 (Wed, 10 Jun 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
    M llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp

  Log Message:
  -----------
  AMDGPU: Stop using getSelectCC in division lowering

This was promoting booleans to i32 to perform a comparison against
them to feed to a select condition. Just use the booleans
directly. This produces the same final code, since the combiner is
unable to undo the mess this creates. I untangled this logic when I
ported this code to GlobalISel, so port the cleanups back.


Compare: https://github.com/llvm/llvm-project/compare/a5099ad918c5...721f8f7530ec


More information about the All-commits mailing list